search

scikit-hep / aghast

Aghast: aggregated, histogram-like statistics, sharable as Flatbuffers.
BSD 3-Clause "New" or "Revised" License
17 stars 8 forks source link

CONTRIBUTING.md #30

Closed LovelyBuggies closed 4 years ago

LovelyBuggies commented 4 years ago

Considering that aghast is under heavy development, I think it would be nice to add something like CONTRIBUTING.md to involve others in.

Maybe split manual installation from README to CONTRIBUTING. I'll work on it and pull you a request after finishing. 😊

jpivarski commented 4 years ago

I do need to learn about how to set up a CONTRIBUTING.md (like, I need to read a few examples to see what they're like), but Aghast is not in active development. The last commit was July 8, 2019. I intend to cycle back to it when other responsibilities are settled, so it's nor orphaned, but it is being left on its own for a while.

For the correction you need to make, finding out what's wrong with "sumw2", you don't need to do any extensive work, just put some print statements into the function that's supposed to deliver the dict with "sumw2" and trace back to find out where it went.

LovelyBuggies commented 4 years ago

you don't need to do any extensive work

Ok.

finding out what's wrong with "sumw2"

Don't worry! I have seen some potential dangerous, e.g. no manipulation when sumw2 == None and all tests are loaded from ROOT cls.