Closed LovelyBuggies closed 4 years ago
closes #29 if merged.
@jpivarski , although you tell me that this is not necessary, I think this would be helpful for someone new to test some conda modules. And you can remove the unnecessary dependencies in "environment.yml" and "requirements.txt".
Please make the name changes above and then tell me when you're done with the PR. I need to have positive confirmation before I merge it to be sure you're not still working on a local copy. Thanks!
@jpivarski I have corrected file names, adding "-test".
Changes in the commits above:
pip install -r requirements.txt
to pip install -r requirements-test.txt
@jpivarski LGTM, do U think it can be merged?
There's one unresolved conversation: use the command "python", rather than "python3", in the README. Not all systems have a "python3" command. You can say that "Python 2 is not supported right now" and that would be enough of a hint.
If you're otherwise done, I'll merge it as soon as that conversation is resolved.
@jpivarski Any other problems? python3
has been python
.
It's great, thanks!
Commit 1391c324886a169f990e5d347ea8ba0dcfb1f236:
numpy.nan != None
trick.if
anelse
to deal with the None problem.By this way, the following code could work: