search

scikit-hep / aghast

Aghast: aggregated, histogram-like statistics, sharable as Flatbuffers.
BSD 3-Clause "New" or "Revised" License
17 stars 8 forks source link

Fix issue #34: huge list problem #38

Closed LovelyBuggies closed 4 years ago

LovelyBuggies commented 4 years ago

I keep track on issue #34 for a long time. I think this is related to the convention of black hook of pre-commit https://github.com/psf/black/issues/1345.

It seems like this is the only solution currently. And I think it doesn't hurt a lot for aghast.

LovelyBuggies commented 4 years ago

Cython failed :(

jpivarski commented 4 years ago

I was looking at that, too, and I have no idea what Cython has to do with any of this. Aghast doesn't use it.

jpivarski commented 4 years ago

The formatting of the test files is not something I'd worry about, though if you're going to stack all the numbers of a list into a block, you don't have to use backslashes (\) because newlines are only significant in Python outside of nested brackets ([ and ], ( and )). Don't worry about changing that, though. I'm accepting this PR (and may need to drop PyPy from the tests if it's doing weird things with Cython).

LovelyBuggies commented 4 years ago

Thx, I see.