The starts and stops of the output of _argminmax would ordinarily be aliased, so changing stops changes starts. That's undesirable if there are any subarrays with a repeated maximum (e.g. issue #176).
This is correcting a correction by @nsmith- in PR #160 (specifically, these changes). I don't know the original case that made a simple [:, :1] ineffective, but the correction should now be completely general.
The
startsandstopsof the output of_argminmaxwould ordinarily be aliased, so changingstopschangesstarts. That's undesirable if there are any subarrays with a repeated maximum (e.g. issue #176).This is correcting a correction by @nsmith- in PR #160 (specifically, these changes). I don't know the original case that made a simple
[:, :1]ineffective, but the correction should now be completely general.