scikit-hep / cabinetry

design and steer profile likelihood fits
https://cabinetry.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
26 stars 21 forks source link

feat: rename model prediction variable in examples #358

Closed alexander-held closed 2 years ago

alexander-held commented 2 years ago

Instead of storing the output of model_utils.prediction in variables named model_*, this PR switches to prediction_*. The use of model in the name could be misleading as the statistical model (pyhf.pdf.Model) is also called "model", and the model prediction is a different object.

* use "prediction" instead of "model" for model_utils.prediction return value names in examples
codecov[bot] commented 2 years ago

Codecov Report

Merging #358 (a1dd25b) into master (d491aab) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #358   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines         2001      2001           
  Branches       326       326           
=========================================
  Hits          2001      2001           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.