Closed alexander-held closed 2 years ago
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:
Coverage data is based on head (
c501013
) compared to base (724e5f8
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
When performing fits via the
fit
API (e.g. MLEs orpyhf.infer.hypotest
viafit.limit
/fit.significance
), the optimizer is set to Minuit bycabinetry
viapyhf.set_backend
. Previously it just stayed this way, but now it instead gets set back to the initial settings (e.g. back toscipy
, which is thepyhf
default).Now that the second RC for
pyhf
0.7.0 is out, the integration test tolerance has to be slightly relaxed for CI to pass. Unclear why #361 is not affected by this. Locally a change in result bisects to https://github.com/scikit-hep/pyhf/pull/1919, but the difference is so small that it likely is down to floating point differences amplifying in the post-fit yield uncertainty calculation.