Closed alexander-held closed 1 year ago
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:
Coverage data is based on head (
c19b5f4
) compared to base (a8ca551
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
348 added the possibility to specify a custom POI via a kwarg in
fit.limit
. This was done by settingmodel.config.poi_name
andmodel.config.poi_index
directly, which is no longer possible after https://github.com/scikit-hep/pyhf/pull/1972 (see https://github.com/scikit-hep/pyhf/issues/1984). https://github.com/scikit-hep/pyhf/pull/1985 adds support forNone
POI values inmodel.config.set_poi
, which allows that API to be used instead. This PR switches to this dedicated API to support temporarily changing the POI, which requires an update of the minimumpyhf
version to0.7.0rc4
.