scikit-hep / cabinetry

design and steer profile likelihood fits
https://cabinetry.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
26 stars 21 forks source link

feat: customizable POI for significance #365

Closed alexander-held closed 1 year ago

alexander-held commented 2 years ago

This is an extension of #348 to also support poi_name in fit.significance. This allows to specify the parameter for which the significance calculation is performed.

The implementation follows #364, and as such also requires at least the pyhf RC 4 for v0.7 that was added there.

* added ability to set POI via poi_name keyword argument in fit.significance
codecov[bot] commented 1 year ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (6a96853) compared to base (0a92ee0). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #365 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 23 23 Lines 2013 2019 +6 Branches 330 331 +1 ========================================= + Hits 2013 2019 +6 ``` | [Impacted Files](https://codecov.io/gh/scikit-hep/cabinetry/pull/365?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep) | Coverage Δ | | |---|---|---| | [src/cabinetry/fit/\_\_init\_\_.py](https://codecov.io/gh/scikit-hep/cabinetry/pull/365/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep#diff-c3JjL2NhYmluZXRyeS9maXQvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.