Closed alexander-held closed 1 year ago
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:
Coverage data is based on head (
5bcfe24
) compared to base (f0f9593
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
matplotlib
3.6 (overview) deprecatesset_tight_layout
and slightly changes figure layout, requiring updates to references. The newlayout_engine
module inmatplotlib
is however not available in earlier versions, andmatplotlib
3.6 requires Python 3.8.We need to check the version of
matplotib
to correctly handle versions <3.6 and >=3.6. Using.__version__
was confirmed as a safe approach to use formatplotlib
. See also https://discuss.python.org/t/dynamic-versions-in-editable-installations/15220/56. When not using.__version__
, the alternative approach to use should beimportlib.metadata.version
(or theimportlib-metadata
port).The coverage is now evaluated with Python 3.8 (previously Python 3.7 was used) to focus on the behavior with the latest
matplotlib
version.Since
pyhf
0.7 brought another API change (https://github.com/scikit-hep/pyhf/pull/2027) compared to RC4, pin to that RC temporarily for CI to work (will be relaxed again right afterwards via #367).The RTD theme for Sphinx causes CI to fail in the latest version due to https://github.com/readthedocs/sphinx_rtd_theme/issues/1343, so that version is also excluded explicitly to fix this.