search

scikit-hep / cabinetry

design and steer profile likelihood fits
https://cabinetry.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
27 stars 21 forks source link

build: Update lower bound of pyhf to v0.7.0 #367

Closed matthewfeickert closed 2 years ago

matthewfeickert commented 2 years ago

Following the release of pyhf v0.7.0, update to the latest API and update the lower bounds.

* Update lower bound of pyhf to v0.7.0
* Update all usage of `.par_names()` to `par_names`
matthewfeickert commented 2 years ago

I can fix this later (unless Alex beats me to it).

alexander-held commented 2 years ago

Thanks! #366 is needed first for CI to pass, I'll get that resolved and then we can get this in too.

codecov[bot] commented 2 years ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (4ec9480) compared to base (278d088). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #367 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 23 23 Lines 2023 2023 Branches 331 331 ========================================= Hits 2023 2023 ``` | [Impacted Files](https://codecov.io/gh/scikit-hep/cabinetry/pull/367?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep) | Coverage Δ | | |---|---|---| | [src/cabinetry/fit/\_\_init\_\_.py](https://codecov.io/gh/scikit-hep/cabinetry/pull/367/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep#diff-c3JjL2NhYmluZXRyeS9maXQvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | | | [src/cabinetry/model\_utils.py](https://codecov.io/gh/scikit-hep/cabinetry/pull/367/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep#diff-c3JjL2NhYmluZXRyeS9tb2RlbF91dGlscy5weQ==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

alexander-held commented 2 years ago

There is also an unrelated new issue in the 3.7 CI when building the documentation (which should work in principle):

Theme error:
An error happened in rendering the page advanced.
Reason: ValueError('too many values to unpack (expected 3)')

I'll have a look at that.

edit: This is https://github.com/readthedocs/sphinx_rtd_theme/issues/1343, I'll fix that too in #366.

alexander-held commented 2 years ago

For completeness, the related API change for .par_names is https://github.com/scikit-hep/pyhf/pull/2027.