scikit-hep / cabinetry

design and steer profile likelihood fits
https://cabinetry.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
26 stars 21 forks source link

feat: sort nuisance parameters by decreasing maximum impact in ranking plot #373

Closed lhenkelm closed 1 year ago

lhenkelm commented 1 year ago

The order of the ranking plot is chosen using the maximum impact across the post-fit impact in up/down direction, rather than the average. Resolves #372.

alexander-held commented 1 year ago

Thanks a lot! The CI failure is expected, will try to fix that via #371 before merging this.

codecov[bot] commented 1 year ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (8dc0104) compared to base (29065b5). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #373 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 23 23 Lines 2023 2023 Branches 320 320 ========================================= Hits 2023 2023 ``` | [Impacted Files](https://codecov.io/gh/scikit-hep/cabinetry/pull/373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep) | Coverage Δ | | |---|---|---| | [src/cabinetry/visualize/\_\_init\_\_.py](https://codecov.io/gh/scikit-hep/cabinetry/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep#diff-c3JjL2NhYmluZXRyeS92aXN1YWxpemUvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.