Closed rmnmllr closed 1 year ago
@alexander-held I'm not sure why the python tests fail, pytest gives an error
> assert "predicted yield is zero in 1 bin(s), excluded from ratio plot" in [
rec.message for rec in caplog.records
]
E AssertionError: assert 'predicted yield is zero in 1 bin(s), excluded from ratio plot' in ['predicted yield is zero in 1 bin(s), excluded from ratio plot']
but this is not something I touched.
Thanks a lot for preparing this! I am afraid it may take me until next week to more carefully look at this, sorry for the slow feedback here.
Thanks a lot for preparing this! I am afraid it may take me until next week to more carefully look at this, sorry for the slow feedback here.
No worries, I'm glad I can contribute in some way! And no rush with this, I can run stuff already locally :)
Patch coverage: 100.00
% and no project coverage change.
Comparison is base (
4645cb8
) 100.00% compared to head (89b4170
) 100.00%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hi @rmnmllr, I added tests to this to get this ready for inclusion in the next version of cabinetry
that I intend to release with #390 also being completed. Thanks a lot for preparing this!
* catch negative total model prediction in visualize.plot_model.data_mc
* handle negative nominal template prediction in visualize.plot_model.templates
Thank you @alexander-held for completing this!
related to issue https://github.com/scikit-hep/cabinetry/issues/388.
Tried
python -m pytest
, did not pass all tests even before modifying anything. No additional errors though after the fix and tested with samples mantioned in issue https://github.com/scikit-hep/cabinetry/issues/388.