Closed alexander-held closed 1 year ago
Patch coverage: 100.00
% and no project coverage change.
Comparison is base (
67f7fd6
) 100.00% compared to head (dbf630d
) 100.00%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
In the presence of partially fixed parameters (currently this only happens for
staterror
modifiers that are constant in some bins due to zero yield + uncertainty, see https://github.com/scikit-hep/pyhf/issues/1944) the previously usedmodel.config.suggested_fixed_as_bool
will not work. Instead,model.config.suggested_fixed
works fine to handle these mixed cases.The same update is made for the counting of the number of unconstrained parameters. This should in principle correctly handle partially fixed
shapefactor
modifiers, however this currently cannot be achieved inpyhf
(see https://github.com/scikit-hep/pyhf/issues/2053). This means the behavior currently cannot be tested.resolves #390