search

scikit-hep / cabinetry

design and steer profile likelihood fits
https://cabinetry.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
26 stars 21 forks source link

build: drop support for Python 3.7 #402

Closed alexander-held closed 1 year ago

alexander-held commented 1 year ago

Following pyhf (https://github.com/scikit-hep/pyhf/pull/2044), this drops support for Python 3.7. The NEP 29 schedule puts Python 3.8+ at Dec 26, 2021, which already was one and a half years ago. The last cabinetry version to support Python 3.7 will presumably remain 0.5.2 (alongside with pyhf version 0.7.1).

This allows dropping the _typing submodule that was used for the Literal type via typing_extensions with Python 3.7.

Ran pyupgrade --py38-plus, which did not seem to introduce any other changes.

The previous drop of Python 3.6 happened in #194. These changes also mean that pre-commit mypy is again testing against the lowest supported version (see #371).

* future versions of cabinetry require at least Python 3.8
* drop support and testing of Python 3.7
* updated pre-commit
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1572423) 100.00% compared to head (ddc523d) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #402 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 23 22 -1 Lines 2078 2068 -10 Branches 334 334 ========================================= - Hits 2078 2068 -10 ``` | [Impacted Files](https://app.codecov.io/gh/scikit-hep/cabinetry/pull/402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep) | Coverage Δ | | |---|---|---| | [src/cabinetry/visualize/plot\_model.py](https://app.codecov.io/gh/scikit-hep/cabinetry/pull/402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep#diff-c3JjL2NhYmluZXRyeS92aXN1YWxpemUvcGxvdF9tb2RlbC5weQ==) | `100.00% <ø> (ø)` | | | [src/cabinetry/visualize/plot\_result.py](https://app.codecov.io/gh/scikit-hep/cabinetry/pull/402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep#diff-c3JjL2NhYmluZXRyeS92aXN1YWxpemUvcGxvdF9yZXN1bHQucHk=) | `100.00% <ø> (ø)` | | | [src/cabinetry/configuration.py](https://app.codecov.io/gh/scikit-hep/cabinetry/pull/402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep#diff-c3JjL2NhYmluZXRyeS9jb25maWd1cmF0aW9uLnB5) | `100.00% <100.00%> (ø)` | | | [src/cabinetry/fit/\_\_init\_\_.py](https://app.codecov.io/gh/scikit-hep/cabinetry/pull/402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep#diff-c3JjL2NhYmluZXRyeS9maXQvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | | | [src/cabinetry/histo.py](https://app.codecov.io/gh/scikit-hep/cabinetry/pull/402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep#diff-c3JjL2NhYmluZXRyeS9oaXN0by5weQ==) | `100.00% <100.00%> (ø)` | | | [src/cabinetry/route.py](https://app.codecov.io/gh/scikit-hep/cabinetry/pull/402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep#diff-c3JjL2NhYmluZXRyeS9yb3V0ZS5weQ==) | `100.00% <100.00%> (ø)` | | | [src/cabinetry/templates/builder.py](https://app.codecov.io/gh/scikit-hep/cabinetry/pull/402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep#diff-c3JjL2NhYmluZXRyeS90ZW1wbGF0ZXMvYnVpbGRlci5weQ==) | `100.00% <100.00%> (ø)` | | | [src/cabinetry/templates/collector.py](https://app.codecov.io/gh/scikit-hep/cabinetry/pull/402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep#diff-c3JjL2NhYmluZXRyeS90ZW1wbGF0ZXMvY29sbGVjdG9yLnB5) | `100.00% <100.00%> (ø)` | | | [src/cabinetry/templates/postprocessor.py](https://app.codecov.io/gh/scikit-hep/cabinetry/pull/402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep#diff-c3JjL2NhYmluZXRyeS90ZW1wbGF0ZXMvcG9zdHByb2Nlc3Nvci5weQ==) | `100.00% <100.00%> (ø)` | | | [src/cabinetry/templates/utils.py](https://app.codecov.io/gh/scikit-hep/cabinetry/pull/402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep#diff-c3JjL2NhYmluZXRyeS90ZW1wbGF0ZXMvdXRpbHMucHk=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.