scikit-hep / cabinetry

design and steer profile likelihood fits
https://cabinetry.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
26 stars 21 forks source link

fix: typing for file opened for writing with click #403

Closed alexander-held closed 1 year ago

alexander-held commented 1 year ago

click opens files for writing lazily, meaning that a file opened for writing is not immediately an io.TextIOWrapper but a click.utils.LazyFile for the purpose of typing: https://click.palletsprojects.com/en/8.1.x/api/#click.File. This was flagged by typeguard version 4.0.0rc4 (which will be adopted after full release via #391).

* fix typing for file opened for writing with click in command line interface
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (787c577) 100.00% compared to head (4b39b04) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #403 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 23 23 Lines 2078 2078 Branches 334 334 ========================================= Hits 2078 2078 ``` | [Impacted Files](https://codecov.io/gh/scikit-hep/cabinetry/pull/403?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep) | Coverage Δ | | |---|---|---| | [src/cabinetry/cli/\_\_init\_\_.py](https://codecov.io/gh/scikit-hep/cabinetry/pull/403?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep#diff-c3JjL2NhYmluZXRyeS9jbGkvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.