search

scikit-hep / cabinetry

design and steer profile likelihood fits
https://cabinetry.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
26 stars 21 forks source link

fix: adopt typeguard version 4.0 #406

Closed alexander-held closed 1 year ago

alexander-held commented 1 year ago

Relax the requirement of typeguard<3 introduced in #392 and adopt version 4.0.

The update of typeguard however now interacts with code coverage calculations, lowering the reported coverage: https://github.com/agronholm/typeguard/issues/356. To avoid this, run pytest for Python 3.8 without typeguard to calculate coverage, and run typeguard only for the remaining Python versions.

resolves #391

* require typeguard>=4.0
* calculate code coverage using Python 3.8 without typeguard enabled
* remove typing workarounds that are no longer required
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (10525d0) 100.00% compared to head (ff2d1ff) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #406 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 22 22 Lines 2068 2068 Branches 334 334 ========================================= Hits 2068 2068 ``` | [Impacted Files](https://app.codecov.io/gh/scikit-hep/cabinetry/pull/406?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep) | Coverage Δ | | |---|---|---| | [src/cabinetry/smooth.py](https://app.codecov.io/gh/scikit-hep/cabinetry/pull/406?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep#diff-c3JjL2NhYmluZXRyeS9zbW9vdGgucHk=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.