scikit-hep / cabinetry

design and steer profile likelihood fits
https://cabinetry.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
26 stars 19 forks source link

chore: use 2x faster black mirror #426

Closed henryiii closed 11 months ago

henryiii commented 11 months ago

Committed via https://github.com/asottile/all-repos

alexander-held commented 11 months ago

Thanks @henryiii! Looks like the latest typeguard release requires a newer typing-extensions version that clashes with the requirements made by tensorflow (which caps the typing-extensions version). This conflict has unfortunately happened before, I'll have a look to fix this externally and can then rebase this for CI to pass.

henryiii commented 11 months ago

I'd bring it up with the TF people, and maybe recommend they remove the cap on this. Very high chance it's actually fine (typing-extensions doesn't break stuff much, and is mostly useful at type-check time, not runtime), and they've loosed some other caps before.

alexander-held commented 11 months ago

Looks like this will be fixed in the next TF release: https://github.com/tensorflow/tensorflow/issues/60687#issuecomment-1655280362.

edit: target for that is Sep 6 according to https://discuss.tensorflow.org/t/upcoming-tensorflow-2-14-branch-cut-release-dates/18220

Will restrict typeguard temporarily to have working CI and then revert that after the next TF release. See #428.

* switch to faster black mirror for pre-commit
codecov[bot] commented 11 months ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (0490607) 100.00% compared to head (47da8b7) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #426 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 22 22 Lines 2072 2072 Branches 338 338 ========================================= Hits 2072 2072 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.