search

scikit-hep / cabinetry

design and steer profile likelihood fits
https://cabinetry.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
26 stars 19 forks source link

Relax typeguard version restriction after next Tensorflow release #428

Closed alexander-held closed 6 months ago

alexander-held commented 11 months ago

typeguard>=4.0.1 requires typing_extension>=4.7.0, which is beyond the upper bound that Tensorflow sets on it. This has already been fixed in Tensorflow (removing the cap) and will go into the next release, expected Sep 6 https://discuss.tensorflow.org/t/upcoming-tensorflow-2-14-branch-cut-release-dates/18220.

In the meantime, just to keep CI running, restrict the typeguard version to avoid the clash (Tensorflow is not a direct dependency of cabinetry and only enters as optional pyhf backend). This is not a great solution but should be good enough, as the next version of Tensorflow in 3 weeks will allow removing that version restriction again anyway.

alexander-held commented 10 months ago

The 2.14 release currently does not work for pyhf: https://github.com/scikit-hep/pyhf/discussions/1595#discussioncomment-7117675.

alexander-held commented 10 months ago

Following https://github.com/scikit-hep/pyhf/pull/2344, this can now be resolved via #440.

alexander-held commented 10 months ago

Unfortunately #440 cannot yet solve this, the latest tensorflow-probability also caps typing-extension: https://github.com/tensorflow/probability/issues/1753.

alexander-held commented 6 months ago

The subsequent releases of TF and tensorflow-probability (which remove the cap) are Python 3.9+, so they do not solve the issue for Python 3.8 CI. One option there might be manually forcing a typing_extension update to a later version (in the CI).