search

scikit-hep / cabinetry

design and steer profile likelihood fits
https://cabinetry.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
26 stars 19 forks source link

feat: support SamplePath overrides for histogram inputs #437

Closed alexander-held closed 10 months ago

alexander-held commented 10 months ago

As discussed in #435 and originally via #433, SamplePath overrides are needed to provide additional flexibility for histogram inputs. This adds support for such overrides. For easier debugging, a new DEBUG level message is also added to report the location of histogram and ntuple inputs.

* support SamplePath overrides when using histogram inputs
* update documentation for histogram inputs
* add debug-level log message with paths to ntuple and histogram inputs
codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2b7c091) 100.00% compared to head (7ba0e62) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #437 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 22 22 Lines 2071 2082 +11 Branches 338 340 +2 ========================================= + Hits 2071 2082 +11 ``` | [Files Changed](https://app.codecov.io/gh/scikit-hep/cabinetry/pull/437?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep) | Coverage Δ | | |---|---|---| | [src/cabinetry/templates/builder.py](https://app.codecov.io/gh/scikit-hep/cabinetry/pull/437?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep#diff-c3JjL2NhYmluZXRyeS90ZW1wbGF0ZXMvYnVpbGRlci5weQ==) | `100.00% <ø> (ø)` | | | [src/cabinetry/contrib/histogram\_creator.py](https://app.codecov.io/gh/scikit-hep/cabinetry/pull/437?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep#diff-c3JjL2NhYmluZXRyeS9jb250cmliL2hpc3RvZ3JhbV9jcmVhdG9yLnB5) | `100.00% <100.00%> (ø)` | | | [src/cabinetry/contrib/histogram\_reader.py](https://app.codecov.io/gh/scikit-hep/cabinetry/pull/437?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep#diff-c3JjL2NhYmluZXRyeS9jb250cmliL2hpc3RvZ3JhbV9yZWFkZXIucHk=) | `100.00% <100.00%> (ø)` | | | [src/cabinetry/templates/collector.py](https://app.codecov.io/gh/scikit-hep/cabinetry/pull/437?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scikit-hep#diff-c3JjL2NhYmluZXRyeS90ZW1wbGF0ZXMvY29sbGVjdG9yLnB5) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.