scikit-hep / cabinetry

design and steer profile likelihood fits
https://cabinetry.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
27 stars 21 forks source link

build: relax typeguard constraints following TensorFlow release #440

Closed alexander-held closed 8 months ago

alexander-held commented 1 year ago

To avoid a typing_extension clash caused by TensorFlow, #429 restricted the typeguard version listed in the test setup extra. Now that an updated TensorFlow version is available, which fixes this clash, the typeguard version restriction can be relaxed again.

The typing-extensions cap introduced in tensorflow-probability has been fixed, but the versions with the fix are Python 3.9+ and therefore cause issues in the CI for 3.8. To avoid this, upgrade the typing_extensions version in the relevant Python 3.8 CI.

resolves #428

* relax version constraint on typeguard as latest TensorFlow release no longer causes dependency clash
* upgrade typing-extensions version in Python 3.8 CI to circumvent dependency clash
codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d5e2241) 100.00% compared to head (d2517cb) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #440 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 22 22 Lines 2082 2082 Branches 340 340 ========================================= Hits 2082 2082 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.