search

scikit-hep / cabinetry

design and steer profile likelihood fits
https://cabinetry.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
26 stars 19 forks source link

fix: ranking plot axis range for normalization factors #465

Closed alexander-held closed 4 months ago

alexander-held commented 4 months ago

As flagged by #463, the impact axis range did not correctly take into account cases where the largest impacts were post-fit. This can happen in particular for normalization factors, which have no pre-fit impact defined.

* take into account both pre- and post-fit impacts when setting ranking plot axis range
* updated pre-commit
codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (a10f48c) to head (a71d23b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #465 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 22 22 Lines 2082 2082 Branches 340 340 ========================================= Hits 2082 2082 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.