search

scikit-hep / decaylanguage

Package to parse decay files, describe and convert particle decays between digital representations.
https://decaylanguage.readthedocs.io
BSD 3-Clause "New" or "Revised" License
42 stars 16 forks source link

chore: update pre-commit hooks #434

Closed pre-commit-ci[bot] closed 4 months ago

pre-commit-ci[bot] commented 4 months ago

updates:

eduardo-rodrigues commented 4 months ago

BTW, concerning a future release - will we have the same issues as with the latest release of Particle where you acted manually and moved to trusted publishers on PyPI? Maybe you got that all done already across project packages?

henryiii commented 4 months ago

Probably, all Scikit-HEP repos had their secrets stripped.

It's not trivial enough to do access all packages, especially ones like iminuit that have custom deploy structures.

henryiii commented 4 months ago

FYI, we need to work on reducing the type ignores. Most of them are probably hiding issues in typing rather than deficiencies in the type checkers.

henryiii commented 4 months ago

Yes, this is the way you can tell it is not using trusted-publishers: https://github.com/scikit-hep/decaylanguage/blob/cb0a861f4bc39e458c6ff372f7ab34ebbd23687f/.github/workflows/wheel.yml#L42

eduardo-rodrigues commented 4 months ago

OK, then I need to find some time to understand how to do what you did for Particle, as there is this package but also scikit-hep and hepunits ...

Yes, I totally agree with you that type ignores are to be avoided as much as possible. I will create now an issue for it.