search

scikit-hep / decaylanguage

Package to parse decay files, describe and convert particle decays between digital representations.
https://decaylanguage.readthedocs.io
BSD 3-Clause "New" or "Revised" License
42 stars 16 forks source link

Add support for EvtGen model HypNonLepton #440

Closed eduardo-rodrigues closed 3 months ago

eduardo-rodrigues commented 3 months ago

FYI @sognetic, with this update all Belle II files in the current version of basf2 are parsed with no issues aside the one file 1263700001.dec, which contains the line 0.5 anti-D*0 mu+ nu_mu PHOTOS PHOTOS HQET3 0.912 1.205 1.15 1.404 0.854; #18.09.2018: updated to main DECAY_BELLE2.DEC and DecayLanguage does not allow for twice the keyword PHOTOS in a decay line - not a bug per se but I would say a buglet. Maybe worth fixing upstream.

sognetic commented 3 months ago

Hi @eduardo-rodrigues , thanks for the notification! I don't have access to upstream anymore but let me ping @GiacomoXT

GiacomoXT commented 3 months ago

@eduardo-rodrigues thanks for having spotted it! Indeed having the keyword PHOTOS twice is useless, I will fix it upstream in basf2.

eduardo-rodrigues commented 3 months ago

Hi both. Glad I could help.

In the future do not hesitate to run the parsing over your files for validation :-).

GiacomoXT commented 3 months ago

Hi both. Glad I could help.

In the future do not hesitate to run the parsing over your files for validation :-).

Sure, it's a good idea.

(Thanks to @sognetic , since a bit of time we have a unit test in place that runs EvtGen with all the new signal decfiles added to basf2 via merge request, so luckily we are not adding anymore broken decfiles! But using DecayLanguage would be definitely faster.)