search

scikit-hep / fastjet

Jet-finding in the Scikit-HEP ecosystem.
https://fastjet.readthedocs.io
BSD 3-Clause "New" or "Revised" License
21 stars 13 forks source link

Add fastjet to conda-forge #133

Open jmduarte opened 1 year ago

jmduarte commented 1 year ago

Inspired by #91.

It would be great to get fastjet on conda-forge (especially in time for the first real release 3.4.0.0, which now appears to be imminent). I'm unsure if we want to make this a requirement for the release. What do others think?

@lgray @jpivarski @chrispap95 @henryiii

lgray commented 1 year ago

In my experience first you make a pypi release then you stick it into conda forge which follows pypi. You can see from https://github.com/conda-forge/staged-recipes/pull/15961 a while ago that going in with an RC or something that's a little wonky can be quite some pain.

jpivarski commented 1 year ago

Getting fastjet into conda-forge would be great!

As @lgray said, the conda-forge is a more frictionless process with non-RC releases. Only the first three digits of the version number (3.4.0) are constrained to match FastJet's; the fourth digit is free to increase as needed, so it is not necessary to get the conda-forge deployment right on the first non-RC attempt.

Also, the way that the conda-forge package gets populated is through the PyPI source wheel (e.g. fastjet-3.4.0.0.tar.gz). As long as the environment on conda-forge can take this tarball and compile all of its packages, it should work.

I'll also bring @chrisburr into this discussion, since he's a conda expert.

jmduarte commented 1 year ago

In progress by @lgray here: https://github.com/conda-forge/staged-recipes/pull/21052

jmduarte commented 1 year ago

@lgray @chrispap95 perhaps the blocker from before (https://github.com/conda-forge/staged-recipes/pull/21052#issuecomment-1307593991) is now resolved by #159 ?

eduardo-rodrigues commented 1 year ago

Adding a comment here so that I keep track of this for the inclusion of fastjet in the scikit-hep metapackage, see the discussions at https://github.com/scikit-hep/scikit-hep/issues/173.

eduardo-rodrigues commented 5 months ago

This is in fact done since a while, see https://github.com/conda-forge/fastjet-feedstock.

lgray commented 5 months ago

Sorta - we got the recipe to work once for one version, and then the next version broke again. 🎉

matthewfeickert commented 5 months ago

Yeah, this should maybe be left open as a reminder that we still need to get the latest versions building and also make them multiplatform (still only Linux at this point).

eduardo-rodrigues commented 5 months ago

Indeed. Sorry for missing those facts.

matthewfeickert commented 5 months ago

Nothing to be sorry about! This is a good reminder that we need to follow up on getting conda-forge setup properly across multiplatforms.