Open matthewfeickert opened 1 year ago
Well, in a given thread it appears once, I don't think that's too bad and if we are going to (somehow) suppress it we should definitely get the authors' approval since this behavior would deviate from the default C++ behavior. What I think is annoying is when working in multithreading environments, e.g., using futures in coffea, a banner is printed for each thread so you end up with a long print out in the beginning. However, I suspect it won't be easy to fix this.
Well, in a given thread it appears once, I don't think that's too bad ... What I think is annoying is when working in multithreading environments, e.g., using futures in coffea, a banner is printed for each thread so you end up with a long print out in the beginning.
It is annoying and really unnecessary. The example you give about multithreading just emphasizes this all the more.
and if we are going to (somehow) suppress it we should definitely get the authors' approval since this behavior would deviate from the default C++ behavior.
I think this should be followed up on. We've successfully gotten Wouter and David Kirkby to happily approve the removal of the RooFit banner (c.f. https://github.com/root-project/root/issues/9954, https://github.com/root-project/root/pull/9965) and the segment of the license that stipulates the banner bit is from 2007 (c.f. https://gitlab.com/fastjet/fastjet/-/commit/8d7e09471180735c78fbe64ec9ad215eab517ed7). As David Kirkby noted in https://github.com/root-project/root/issues/9954#issuecomment-1049023607
No serious library nowadays has such a banner, why should RooFit have it.
I agree with that assessment today, but the open-source landscape was quite different when that banner originated, over 20 years ago.
It is unfortunate that the FastJet authors have disabled Issues on the FastJet GitLab so the only way to discuss this with them would be over email.
This might be something to take up with the FastJet authors themselves, but anytime that
fastjet.ClusterSequence
is called the FastJet banner gets printed to stdout.For
fastjet
v3.4.0.5
produces
To have additional output beyond what was asked for is pretty annoying. While the removal is ultimately something to discuss with the FastJet authors the banner isn't something that is required in the license to produce at runtime, so can it be caught and suppressed until it can be removed altogether?
edit: Well, depending on how you interpret "modified program" in