search

scikit-hep / fastjet

Jet-finding in the Scikit-HEP ecosystem.
https://fastjet.readthedocs.io
BSD 3-Clause "New" or "Revised" License
21 stars 14 forks source link

dask tests suddenly fail #228

Closed lgray closed 1 year ago

lgray commented 1 year ago

https://github.com/scikit-hep/fastjet/blob/main/tests/test_008-dask.py#L99

No longer passes as of this week. It passed on Friday with 2.2.3 with no problem?

@agoose77 @jpivarski 

E           TypeError: __class__ assignment: 'MomentumArray4D' object layout differs from 'Array'
E           
E           This error occurred while calling
E           
E               ak.zip(
E                   arrays = {'pt': <Array-typetracer [...] type='## * var * float32'>, '...
E                   depth_limit = None
E                   parameters = None
E                   with_name = 'Momentum4D'
E                   right_broadcast = False
E                   optiontype_outside_record = False
E                   highlevel = True
E                   behavior = {('*', 'Vector2D'): <class 'vector.backends.awkward.Vector...
E               )
agoose77 commented 1 year ago

@lgray this is concerning — we're also seeing this in our CI in main, overnight. I can't reproduce this locally.

Will keep you posted RE diagnosis.

agoose77 commented 1 year ago

OK, I'm now able to reproduce this on my machine. You can drop the troubleshooting, I'll take figure it out on our end!

agoose77 commented 1 year ago

This PR should fix it (NumPy 1.25.0 added __slots__ to a class, breaking our mixin behavior decorator) https://github.com/scikit-hep/awkward/pull/2534

lgray commented 1 year ago

fixed with awkward 2.2.4