search

scikit-hep / fastjet

Jet-finding in the Scikit-HEP ecosystem.
https://fastjet.readthedocs.io
BSD 3-Clause "New" or "Revised" License
21 stars 14 forks source link

ci: fix failing tests after update to upload-artifact v4 #273

Closed chrispap95 closed 9 months ago

chrispap95 commented 9 months ago

upload-artifact v4 cannot overwrite artifacts and this causes the tests to fail.

chrispap95 commented 9 months ago

So it fixes the overwrite issue in the CI wheel tests. The real question is if it handles correctly the full wheel building process. Perhaps someone more knowledgeable should take a look at these changes.

lgray commented 9 months ago

I personally don't use this action so I'm not sure if this will be correct.

chrispap95 commented 9 months ago

I implemented the changes as they are suggested in https://github.com/scientific-python/cookie/pull/350 I am quite confident they are okay. I will merge tonight if there are no objections.