search

scikit-hep / hist

Histogramming for analysis powered by boost-histogram
https://hist.readthedocs.io
BSD 3-Clause "New" or "Revised" License
123 stars 23 forks source link

[FEATURE] allow different plotting styles for `plot_ratio` #547

Open jonas-eschle opened 8 months ago

jonas-eschle commented 8 months ago

Describe the problem, if any, that your feature request is related to

plot_ratio currently uses the default histplot from mplhep, see https://github.com/scikit-hep/hist/blob/41e1effc09fc345168094d5a2222dfce3d72d0a5/src/hist/plot.py#L654

Currently, there is no possibility to customize this plot, i.e. to change the plot style (errorbars, filled, etc), activate yerr etc.

Describe the feature you'd like

Being able to customize it would mean to be able to pass through arguments (and I think there is technically no reason not to allow this). I would suggest an argument histplotkwargs or something similar that is dict-like, passed in and expanded in histplot.

I can gladly make the PR if that's inline with the design.

Alternative

Of course, the refactoring as proposed here https://github.com/scikit-hep/hist/issues/192 would very well solve this problem too

AlbertoPdRF commented 1 month ago

Hi,

Just checking: is there any chance of this issue getting addressed? Being able to style this kind of plot to match the style of others would be awesome.