search

scikit-hep / histbook

Versatile, high-performance histogram toolkit for Numpy.
BSD 3-Clause "New" or "Revised" License
109 stars 9 forks source link

Added test coverage #41

Closed eduardo-rodrigues closed 6 years ago

eduardo-rodrigues commented 6 years ago

I reckon this test coverage history will be handy for future developments.

jpivarski commented 6 years ago

I agree— I intend to accept it once I get to a laptop and look at it more carefully.

eduardo-rodrigues commented 6 years ago

I agree with all your comments, Jim. These tests are not the perfect thing indeed. But they do have some info at the same time.

I would say it's just fine to have the Altair dependency for the tests, yes. Valid plots are already a good way towards a reassurance that the code is doing the right thing. Other than that, only examples/tutorials can tell you more.

Thanks for the merge.