search

scikit-hep / mplhep

Extended histogram plotting on top of matplotlib and HEP collaboration compatible styling
https://mplhep.readthedocs.io
MIT License
185 stars 64 forks source link

Update label.py #433

Open ruelasvh opened 1 year ago

ruelasvh commented 1 year ago

Remove hard-coded lumi for loc==4

andrzejnovak commented 1 year ago

Thanks @ruelasvh. Can you also mod the failing test such that it shows the behaviour when lumi number is supplied?

ruelasvh commented 1 year ago

Thanks @ruelasvh. Can you also mod the failing test such that it shows the behaviour when lumi number is supplied?

Hi @andrzejnovak I've updated the MR. I needed to add a fix for the default 13 TeV com. Now the tests should be passing.

jonas-eschle commented 6 months ago

Hi @ruelasvh , what is the status of this? Can you maybe just rebase? Are there more changes to come?