search

scikit-hep / numpythia

The interface between PYTHIA and NumPy
GNU General Public License v3.0
36 stars 11 forks source link

Attempt to add wrapper on Pythia's Sphericity class #28

Closed delgadoandrea closed 3 years ago

delgadoandrea commented 3 years ago

Hello,

I am trying to add a wrapper to Pythia's sphericity class without having a clear idea of how to do it. Any help/pointers would be greatly appreciated. If successful, I would like to add a few other capabilities, for jet finding, e.g., thrust, etc.

Thanks a lot for your time!

kratsg commented 3 years ago

This looks right. How do you expect it to be used? (/cc @henryiii if you have suggestions on the organization).

henryiii commented 3 years ago

If you can add a test, that would be fantastic, then we could see how this is going to be used (@kratsg comment).

henryiii commented 3 years ago

I've fixed the CI file to build on pull requests, and closed/reopened to trigger a build.

eduardo-rodrigues commented 3 years ago

Only looking at this now. Very nice to see contributions here :-). Would you have use cases for other classes missing?

eduardo-rodrigues commented 3 years ago

Brilliant, @henryiii! Seems ready to be merged 👍 !

henryiii commented 3 years ago

This is a start for @delgadoandrea, but it doesn't really do anything interesting yet. I assume you need some Events to analyze, and I'm not sure where those should be from.

This pattern should be a good one to start from, though.

eduardo-rodrigues commented 3 years ago

Yes. In other words we need @delgadoandrea to add an example usage and potentially a bit more code.

eduardo-rodrigues commented 3 years ago

Hi @delgadoandrea, can you comment on the discussion above and your plans? Just so that we know the best course of action. Advance thanks,.

eduardo-rodrigues commented 3 years ago

Hello @delgadoandrea, can you comment on whether you will commit an example here? Otherwise we should not leave this PR open forever. Advance thanks.

eduardo-rodrigues commented 3 years ago

As @delgadoandrea never bothered to reply to the several messages it is fair to say that he no longer is interested. This preparatory piece of word is ready thanks to @henryiii, hence merging now.