scikit-hep / numpythia

The interface between PYTHIA and NumPy
GNU General Public License v3.0
36 stars 11 forks source link

Remove private copy of six package and rather use external version #6

Closed eduardo-rodrigues closed 6 years ago

eduardo-rodrigues commented 6 years ago

As per our discussion @henryiii.

henryiii commented 6 years ago

You'll need to remove 'numpythia.extern', from the setup.py main function, too. This is one of the reasons listing them there manually is a bad idea...

eduardo-rodrigues commented 6 years ago

Yep, noticed it and remove it - had indeed overlooked, not seeing it when grep'ing for 'six' somehow.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 8


Totals Coverage Status
Change from base Build 4: 0.0%
Covered Lines: 0
Relevant Lines: 22

💛 - Coveralls
coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 33


Totals Coverage Status
Change from base Build 23: 35.2%
Covered Lines: 22
Relevant Lines: 22

💛 - Coveralls
eduardo-rodrigues commented 6 years ago

Hi @henryiii, the issue is that same as the one we talked about yesterday. It's got to do with a mix-up when unittest tries to run. Will you have time to make the move to pytest as you suggested?

henryiii commented 6 years ago

Yes, later today. Would you like me to work on this branch or a new one and then you can merge this one?

eduardo-rodrigues commented 6 years ago

Brilliant! As you prefer … We can even change the PR title to incorporate both things.

henryiii commented 6 years ago

Okay, I'll work here then.

eduardo-rodrigues commented 6 years ago

Thanks a lot @henryiii!