Closed maxnoe closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.20%. Comparing base (
4f8e0cb
) to head (bb574cc
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks very much @maxnoe for the speedy action 👍! I've got something urgent to finish today but will get back to this really soon.
I hope this also handles the feature https://github.com/scikit-hep/particle/issues/620.
Oh, I see you got those quotes from the docstring for nuclei, which I probably got from somewhere such as periodictable when including the nuclei. It would be easier if no nucleus codes existed for the proton and neutron, but ...
Indeed the scheme can also handle hypernuclei with a p or n being replaced by a Lambda. Some are known, and for example have been studied by ALICE and LHCb :-).
I hope this also handles the feature https://github.com/scikit-hep/particle/issues/620.
Yes, see the tests
Yes, from my side this is ready
Thank you again.
@all-contributors please add @maxnoe for code
@eduardo-rodrigues
I've put up a pull request to add @maxnoe! :tada:
I added two dicts that are build at import time, one mapping one pdgid to the alternative representation to implement the comparison and one with the "preferred" pdgid used for
__hash__
and to makefrom_name
work and always return the same pdgid.Edit: that's actually the official recommendation:
From that I infer though, that neutron and proton are not the only cases, also the delta resonance at least.
Closes https://github.com/scikit-hep/particle/issues/620.