search

scikit-hep / probfit

Cost function builder. For fitting distributions.
http://probfit.readthedocs.io/
MIT License
51 stars 30 forks source link

Minor fixes: spelling + unused imports/variables #54

Closed kreczko closed 6 years ago

kreczko commented 10 years ago

I've tidied up the easy bits as I found them. Most of the unused variables initiations where removed (var = None) since they are properly initiated only a few lines further.

Maybe there was even a bug where previously error_ret was initiated with None but err_ret was set.

cdeil commented 8 years ago

@kreczko - This should still be merged, right?

Maybe you could rebase this on master and force push so that travis-ci runs first?

(I'm not familiar with the code or have time to look, so I can't judge the changes by the diff. I just want to get Python 3 and the Sphinx build running again here.)

eduardo-rodrigues commented 6 years ago

Hi @kreczko, this PR is rather old but does contain several fixes. Do you want to try and rebase, to get this PR sorted out?

kreczko commented 6 years ago

@eduardo-rodrigues sure, will put it on my list for tomorrow, I've completely forgot about this one :D

kreczko commented 6 years ago

OK, this has been done. Please have a look :)

eduardo-rodrigues commented 6 years ago

I'm no expert in this package but will have a look. I also asked Hanks to have a more expert look …

Thanks a lot for the speedy update BTW!

HDembinski commented 6 years ago

Looks good now, thank you for the PR!