search

scikit-hep / probfit

Cost function builder. For fitting distributions.
http://probfit.readthedocs.io/
MIT License
51 stars 30 forks source link

Pinning iMinuit version #89

Closed henryiii closed 6 years ago

henryiii commented 6 years ago

This should fix the build errors for now. iMinuit 1.3+ seems to have a bug where it can't read an AddPdf's parameters.

eduardo-rodrigues commented 6 years ago

Hi @henryiii, the tests still fail and I see iminuit 1.3.3 being used. Maybe you need to add a tests_require to make sure the tests use iminuit <= 1.2? So something like tests_require = ['iminuit<"1.3"'], in setup.py.

eduardo-rodrigues commented 6 years ago

Hi @henryiii, I'm totally puzzled, Travis is still installing iminuit 1.3.3 in spite of these 2 lines added in the MR! What's going on?

eduardo-rodrigues commented 6 years ago

I believe this can now be closed given PR https://github.com/scikit-hep/probfit/pull/91.