Closed matthewfeickert closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.28%. Comparing base (
c09738d
) to head (c97bb40
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@MeeseeksDev backport to release/v0.7.x
Owee, I'm MrMeeseeks, Look at me.
There seem to be a conflict, please backport manually. Here are approximate instructions:
git checkout release/v0.7.x
git pull
Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 adddb0797c564a0158a8e2e69a58ee1f98604bf7
You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #2452: build: Determine tensorflow-probability requirements from python version'
git push YOURFORK release/v0.7.x:auto-backport-of-pr-2452-on-release/v0.7.x
"Backport PR #2452 on branch release/v0.7.x (build: Determine tensorflow-probability requirements from python version)"
And apply the correct labels and milestones.
Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!
Remember to remove the Still Needs Manual Backport
label once the PR gets merged.
If these instructions are inaccurate, feel free to suggest an improvement.
Description
'tensorflow'
extra into two different conditional groups bypython_version
.tensorflow
v2.16.1
, multiple changes were made that simplifies the installation oftensorflow
acrossplatform_machine
andKeras
v3.0
was adopted.tensorflow-probability
did not adoptKeras
v3.0
, but instead requirestf-keras
. Starting intensorflow-probability
v0.24.0
the'tensorflow-probability[tf]'
extra was added which includes all the required dependencies to be able to usetensorflow-probability
withtensorflow
v2.15+
.tensorflow
v2.16.1
andtensorflow-probability
v0.24.0
support Python 3.9+, so for Python 3.8 support the'tensorflow'
requirements need to use the previous more verbose conditionals.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: