Closed matthewfeickert closed 6 months ago
This won't get properly fully tested until Python 3.12 is added to the CI matrix.
Attention: Patch coverage is 0%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 98.21%. Comparing base (
50f1076
) to head (7df47f2
).
Files | Patch % | Lines |
---|---|---|
src/pyhf/writexml.py | 0.00% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team.
@meeseeksdev backport to release/v0.7.x
Description
Resolves #2453
In Python 3.14 testing the truth value of an
xml.etree.ElementTree.Element
is deprecated and will raise an exception. As of Python 3.12 this behavior will raise aDeprecationWarning
:To avoid this, determine the truth element by using the
elem is not None
method.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: