scikit-hep / pyhf

pure-Python HistFactory implementation with tensors and autodiff
https://pyhf.readthedocs.io/
Apache License 2.0
274 stars 81 forks source link

feat: Use 'method' arg for jax.numpy.percentile #2522

Closed matthewfeickert closed 2 weeks ago

matthewfeickert commented 2 weeks ago

Description

DeprecationWarning: The interpolation= argument to 'percentile' is deprecated. Use 'method=' instead.

The CI is failing given another DeprecationWarning fixed in PR https://github.com/scikit-hep/pyhf/pull/2523.

Checklist Before Requesting Reviewer

Before Merging

For the PR Assignees:

* Change the argument name in jax.numpy.percentile from 'interpolation' to 'method'.
  No change to the lower bounds on jax and jaxlib is required as 'method' already
  existed as an argument in jax v0.4.1. This just deprecates the use of 'interpolation'.
   - Avoids the following DeprecationWarning in jax v0.4.29+:

     > DeprecationWarning: The interpolation= argument to 'percentile' is deprecated.
     > Use 'method=' instead.
   - c.f. https://github.com/google/jax/pull/21267
matthewfeickert commented 2 weeks ago

@meeseeksdev backport to release/v0.7.x