scikit-hep / pyhf

pure-Python HistFactory implementation with tensors and autodiff
https://pyhf.readthedocs.io/
Apache License 2.0
283 stars 83 forks source link

run repo2docker in CI #918

Open lukasheinrich opened 4 years ago

lukasheinrich commented 4 years ago

Description

right now we trigger a binder build but i'm not sure, do we get a response / feedback iif the bulid fails? We could use repo2docker to do the binder-like build locally

https://twitter.com/m_deff/status/1277064783662141441

matthewfeickert commented 4 years ago

Right now we trigger a binder build but i'm not sure, do we get a response / feedback if the bulid fails?

No. trigger_binder.sh just curls the endpoint and gives the return code

https://github.com/scikit-hep/pyhf/blob/64dbce070156945f6bb524f79ee6e23d26b52f01/binder/trigger_binder.sh#L6-L16

and as we're using the postBuild Binder config which is basically just installing how we would in CI

https://github.com/scikit-hep/pyhf/blob/64dbce070156945f6bb524f79ee6e23d26b52f01/binder/postBuild#L1-L2

the repo2docker build on the Binder side shouldn't fail. That being said though, the idea of using repo2docker in CI (to test and prebuild the Docker image for Binder so that work was offloaded from them) were the reasons that I was looking at machine-learning-apps/repo2docker-action (and why there is now a pyhf/binder Docker image). The discussions with Tim and Chris on these Issues:

make it seem like it might not be a good fit for us as we want to use Binder config files in the top level binder/ dir.

@lukasheinrich did you have additional ideas related to this? Additionally, can you elaborate on what you and @rochaporto were thinking about here?