Closed jpivarski closed 9 months ago
Now
% fgrep -r 'NotImplementedError("TODO ' src | wc -l
33
The remaining 8 check-boxes should bring it down by 7, down to 26 TODOs. (The accounting changed when I converted assertions into NotImplementedError
.)
Now
% fgrep -r 'NotImplementedError("TODO ' src | wc -l
23
Yes, I got rid of a few others along the way (arguments in ragged.array
functions).
All the rest of the NotImplementedError
TODOs are in issues. They'll be addressed one at a time, as needed.
assert False, "TODO"
withraise NotImplementedError
(the mypy constraint no longer exists).arange
(from NumPy/CuPy)empty
(from NumPy/CuPy)eye
(from NumPy/CuPy)from_dlpack
(from NumPy/CuPy)full
(from NumPy/CuPy)linspace
(from NumPy/CuPy)ones
(from NumPy/CuPy)zeros
(from NumPy/CuPy)can_cast
(from NumPy)finfo
(from NumPy)iinfo
(from NumPy)result_type
(from NumPy)astype
(from Awkward)empty_like
(from Awkward)full_like
(from Awkward)ones_like
(from Awkward)zeros_like
(from Awkward)broadcast_arrays
(from Awkward)concat
(from Awkward)nonzero
andwhere
(from Awkward; the 1-arg and 3-arg cases)__dlpack__
and__dlpack_device__
(only for rectilinear arrays)__getitem__
__len__
(and declare it to be aSequence
orSized
or something)__setitem__
__iter__
__init__
'scopy
argument should do adeepcopy
expand_dims
(from a slice)squeeze
(from a slice)take
(from a slice)This would reduce our 51 TODOs down to 20 (by filling in 31).