scikit-hep / root_pandas

A Python module for conveniently loading/saving ROOT files as pandas DataFrames
MIT License
109 stars 35 forks source link

changed the default value of the name of the TTree created by to_root #42

Closed ttekampe closed 6 years ago

ttekampe commented 7 years ago

default is a c++ key word and therefore not a good choice for the name of a TTree

maxnoe commented 7 years ago

DecayTree seems to be Really application specific. Does not seem to be a good default at all.

ttekampe commented 7 years ago

Ok I dont care about the default value of the name. Its just that if it is a c++ keyword, you can run into troubles when opening the file in an interactive ROOT session.

So if you like we can call it my_ttree

eduardo-rodrigues commented 6 years ago

Hi @chrisburr, is this not ready to be merged ;-)?

chrisburr commented 6 years ago

Yes it is! Thank you @ttekampe 👍