search

scikit-hep / root_pandas

A Python module for conveniently loading/saving ROOT files as pandas DataFrames
MIT License
109 stars 35 forks source link

setup.py: update of URL and authors/maintainers #57

Closed eduardo-rodrigues closed 6 years ago

eduardo-rodrigues commented 6 years ago

@chrisburr, would you consider updating the info in the setup.py file as follows? Seems nicer to me for a community package. I fixed the URL in any case. There is also the issue of the license. I would push for a BSD-3 license as we have for all Scikit-HEP projects, where possible. Could you give that a thought? This would require some additions as a 1-line header to the various files, see the other projects ... Let me know :-). Thanks.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 91.346% when pulling 79b5bc658276254e1def22ecb3f966762317a590 on eduardo-setup-info into 42d6fbffbb55cad568d1e492912c4e089be6006b on master.

eduardo-rodrigues commented 6 years ago

Any comments @chrisburr ?

chrisburr commented 6 years ago

I wasn't aware of the maintainer field but yes this is a nicer.

@ibab As this package is mostly your work, do you have any objections to it being BSD-3 instead of MIT to be more consistent with other scikit-hep packages?

eduardo-rodrigues commented 6 years ago

Shall we just create an issue for the question about licensing and accept this PR? Seems the way to go :-).

chrisburr commented 6 years ago

Yes!