search

scikit-hep / root_pandas

A Python module for conveniently loading/saving ROOT files as pandas DataFrames
MIT License
109 stars 35 forks source link

Fix recursive brace expansion #65

Closed tmadlener closed 6 years ago

tmadlener commented 6 years ago

This addresses and solves #64 and fixes the recursive expansion while keeping branches with braces in their names working as they should.

I have also run some timing tests and it basically doesn't change w.r.t. to the previous solution.

The solution is a copy from https://rosettacode.org/wiki/Brace_expansion#Python with some minor adaptions to clearer variable names and at least a sentence describing the functionality. I am not entirely sure about the licensing but as far as I can tell it should be OK.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.7%) to 90.351% when pulling 1a7b20ff166740ae69694dc283bd4fa9cd069871 on tmadlener:fix-recursive-brace-expansion into b7f74796de41313d10c65533671266163cb59999 on scikit-hep:master.

chrisburr commented 6 years ago

Hi @tmadlener, thanks for fixing this!

I've tested it locally and it works (Travis is broken at the moment) so LGTM! 👍