search

scikit-hep / root_pandas

A Python module for conveniently loading/saving ROOT files as pandas DataFrames
MIT License
109 stars 35 forks source link

read_root not compatible to new pandas version #82

Closed JLammering closed 5 years ago

JLammering commented 5 years ago

As announced in older pandas versions the read_root method is not compatible anymore in new pandas versions like 0.25. The announcement for example in 0.24.2 is: /opt/miniconda/envs/root_forge_36_test/lib/python3.6/site-packages/root_pandas/readwrite.py:320: FutureWarning: '.reindex_axis' is deprecated and will be removed in a future version. Use '.reindex' instead. df = df.reindex_axis(columns, axis=1, copy=False)

The error in pandas version 0.25 is: File "/opt/miniconda/envs/root_forge_36_test/lib/python3.6/site-packages/root_pandas/readwrite.py", line 278, in read_root return convert_to_dataframe(arr) File "/opt/miniconda/envs/root_forge_36_test/lib/python3.6/site-packages/root_pandas/readwrite.py", line 320, in convert_to_dataframe df = df.reindex_axis(columns, axis=1, copy=False) File "/opt/miniconda/envs/root_forge_36_test/lib/python3.6/site-packages/pandas/core/generic.py", line 5180, in __getattr__ return object.__getattribute__(self, name) AttributeError: 'DataFrame' object has no attribute 'reindex_axis‘

eduardo-rodrigues commented 5 years ago

@chrisburr should comment but we could probably make a simple release with an update of dependencies, modulo fixes such as the one neeed here. Would you be willing to prepare a PR with the fix? Thanks.

chrisburr commented 5 years ago

Thanks for the report! A fixed release (0.7.0) is working it's way through the CI and will be available soon.