search

scikit-hep / scikit-hep-testdata

A common package to provide example files (e.g., ROOT) for testing and developing packages against.
BSD 3-Clause "New" or "Revised" License
13 stars 15 forks source link

Add DAOD_PHYSLITE_21.2.108.0.art.pool.root from Coffea tests #132

Closed lobis closed 11 months ago

lobis commented 11 months ago

Add https://github.com/CoffeaTeam/coffea/blob/4ca19036db6be9d30380077e1d185eaa816d2209/tests/samples/DAOD_PHYSLITE_21.2.108.0.art.pool.root to test https://github.com/scikit-hep/uproot5/issues/1035.

lobis commented 11 months ago

Feel free to merge this PR (I don't have write access to this repository).

Moelf commented 11 months ago

I low key want to wait for the PR that fixes this issue to be merged at the same time

jpivarski commented 11 months ago

This only adds a file, so it seems to me that it would make more sense to merge it now.

The only reason I can see to hold back is if you think this (relatively large, 1.75 MB) file might change before the PR is done.

lobis commented 11 months ago

I low key want to wait for the PR that fixes this issue to be merged at the same time

This only adds a file, so it seems to me that it would make more sense to merge it now.

The only reason I can see to hold back is if you think this (relatively large, 1.75 MB) file might change before the PR is done.

I agree it makes sense to wait for the issue to be resolved, maybe this file ends up being useless.

With https://github.com/scikit-hep/uproot5/pull/1036/commits/50b9ca48c824d5763bf2fc8adf0b30d5f3090820 I'll load the file from my fork until this is merged, so we can wait until the issue is resolved.

On a sidenote, I think it would be useful to be able to fetch files from a forked scikit-hep-testdata repository (the github url for the base repository is hardcoded). Not sure if there is an easy way to do this though.

lobis commented 11 months ago

I updated https://github.com/scikit-hep/uproot5/pull/1036 to use another file already in the test data repository that is able to reproduce the same issue, so there is no need to add the file from this PR after all.