scikit-hep / scikit-hep-testdata

A common package to provide example files (e.g., ROOT) for testing and developing packages against.
BSD 3-Clause "New" or "Revised" License
13 stars 15 forks source link

Add powheg-box-v2 lhe testfiles #135

Closed APN-Pucky closed 10 months ago

APN-Pucky commented 10 months ago

LHE files for several POWHEG-BOX-V2 processes https://powhegbox.mib.infn.it/ (process details are in the papers for specific process listed on their webpage)

The specific powheg run parameter are included in the beginning comment of the lhe files and correspond to the testrun configurations provided with the powheg box code.

This does not include all processes available, but only a descriptive subset of different setups and processes:

For https://github.com/scikit-hep/pylhe/pull/220

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a3d7245) 69.78% compared to head (129628b) 69.78%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #135 +/- ## ======================================= Coverage 69.78% 69.78% ======================================= Files 3 3 Lines 139 139 ======================================= Hits 97 97 Misses 42 42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

eduardo-rodrigues commented 10 months ago

Hi. For reference can you edit the top-level box to explain what the various files are? This is useful for the future.

This is a very useful addition and we should merge and release. WDYT @jpivarski?

APN-Pucky commented 10 months ago

oh, yes that makes sense. Done.

eduardo-rodrigues commented 10 months ago

@all-contributors please add @APN-Pucky for data.

allcontributors[bot] commented 10 months ago

@eduardo-rodrigues

I've put up a pull request to add @APN-Pucky! :tada:

jpivarski commented 10 months ago

You already merged it, but yes this is good.

eduardo-rodrigues commented 10 months ago

Thanks and sorry for the rush, Jim. It was a crazy day and I acted where I could when I had a bit of time. Dunno if you have anything else in the pipeline or if you would be happy to make a new release to finalise the enhancement in pylhe? Advance thanks.

jpivarski commented 10 months ago

I'm glad you went ahead without waiting for me. Adding a few kilobyte-sized files to support pylhe is definitely a good use of this repo.

eduardo-rodrigues commented 10 months ago

@jpivarski, I'm not sure if you've been doing anything special for the releases but I tagged https://github.com/scikit-hep/scikit-hep-testdata/releases/tag/v0.4.36 and it's not yet on PyPI after 5 minutes or so, which is strange.

jpivarski commented 10 months ago

You have to make a GitHub release to trigger PyPI deployment, not just a tag. When you make a GitHub release, you can use this existing tag, though.

eduardo-rodrigues commented 10 months ago

Thanks. But I thought that is what I did at https://github.com/scikit-hep/scikit-hep-testdata/releases? I'm confused as I proceeded as I do for Particle and DecayLanguage. Some setting must be different. If you see the issue, can you fix?

jpivarski commented 10 months ago

You're right, and I was looking for this thread (on my phone) to follow up, but couldn't find it. I see the release, so it should have triggered. But also, I don't even see the GitHub Action for it in the actions tab or its definition in .github/workflows. I know this has had a GitHub release-triggered deployment, because that's how I've always done it.

eduardo-rodrigues commented 10 months ago

Thanks for the check. Strange indeed.

In the meantime the conda release got done and merged, see https://github.com/conda-forge/scikit-hep-testdata-feedstock/pull/53.

eduardo-rodrigues commented 10 months ago

I decided to upload manually to PyPI to get this done.