scikit-hep / scikit-hep-testdata

A common package to provide example files (e.g., ROOT) for testing and developing packages against.
BSD 3-Clause "New" or "Revised" License
13 stars 15 forks source link

chore: update RNTuple files to RC2 #144

Closed ariostas closed 7 months ago

ariostas commented 8 months ago

I used a recent version of ROOT to regenerate the RNTuple files with the RC2 spec. I also removed the duplicate files uproot_ntuple_* that I mentioned in #143. I'll mark this as a draft for now since it should be merged alongside https://github.com/scikit-hep/uproot5/pull/1115 so as to not break any CI workflows.

Closes #143

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.78%. Comparing base (daba9d1) to head (c6c2c5c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #144 +/- ## ======================================= Coverage 69.78% 69.78% ======================================= Files 3 3 Lines 139 139 ======================================= Hits 97 97 Misses 42 42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jpivarski commented 8 months ago

xxhash is not included in Pyodide, so making it a strict dependency in Uproot would prevent Uproot from being usable in JupyterLite.

image

Is the xxhash algorithm available in cramjam? If so, then we can absolutely depend on it in that way. Also, the cramjam authors have been very responsive to requests—they might be able to add it if it's not already included. (I assume it's a single function without dependencies.)

ariostas commented 8 months ago

I replied to your comment in https://github.com/scikit-hep/uproot5/pull/1115 to continue the thread there.

jpivarski commented 7 months ago

Merging this PR, which replaces the RNTuple files with the latest format, now that scikit-hep/uproot5#1115 is ready to use them. I'll make a release immediately afterward.