search

scikit-hep / scikit-hep-testdata

A common package to provide example files (e.g., ROOT) for testing and developing packages against.
BSD 3-Clause "New" or "Revised" License
13 stars 15 forks source link

feat: add more RNTuple files #151

Closed ariostas closed 5 months ago

ariostas commented 5 months ago

I added three more RNTuple files that have been useful to test and debug uproot. These files were created and used by @Moelf for UnROOT testing, and can be found here.

Moelf commented 5 months ago

it may be a good idea to copy the source code to https://github.com/scikit-hep/scikit-hep-testdata/tree/main/dev/make-root and generate yourself to make sure!

ariostas commented 5 months ago

Thanks @Moelf! For Run2012BC_DoubleMuParked_Muons_rntuple_1000evts.root I couldn't find the original Run2012BC_DoubleMuParked_Muons.root file in the UnROOT repo. For test_ntuple_extension_columns.root, I don't have access to a raw ATLAS file. And I'm not sure how DAOD_TRUTH3_RC2.root was generated.

ariostas commented 5 months ago

For Run2012BC_DoubleMuParked_Muons_rntuple_1000evts.root I couldn't find the original Run2012BC_DoubleMuParked_Muons.root file in the UnROOT repo.

Sorry, I just realized that that's a public file.

Moelf commented 5 months ago

oh you're right... yeah those files are a bit cryptic, indeed I had to produce them with ATLAS stuff. This is as good as it can be for the moment I think

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.00%. Comparing base (9ed1610) to head (375691a). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #151 +/- ## ========================================== + Coverage 69.78% 70.00% +0.21% ========================================== Files 3 3 Lines 139 140 +1 ========================================== + Hits 97 98 +1 Misses 42 42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ariostas commented 5 months ago

I added partial instructions for how to generate these files, like in the UnROOT repo.

I'll look into writing some script to generate similar test files without having to use any ATLAS tools.

ariostas commented 5 months ago

@jpivarski seems like I can't request a reviewer since I'm not a member of this repo (or scikit-hep), but this is ready for review now.

jpivarski commented 5 months ago

It's ready: https://pypi.org/project/scikit-hep-testdata/0.4.44/