search

scikit-hep / scikit-hep-tutorials

Ecosystem tutorials, demos, examples
https://scikit-hep.org/scikit-hep-tutorials
BSD 3-Clause "New" or "Revised" License
8 stars 2 forks source link

Add a tutorial using hepunits #4

Closed eduardo-rodrigues closed 4 years ago

eduardo-rodrigues commented 4 years ago

Hi @HDembinski, @mayou36, I finally took a bit of time to get back to this tutorials package following our chats at https://github.com/scikit-hep/scikit-hep-tutorials/issues/2!

I have a bunch of material from a tutorial I gave at DESY in early March. Let me start with an easy one to see what you think :-). You can easily visualise the tutorial at https://nbviewer.jupyter.org/github/scikit-hep/scikit-hep-tutorials/blob/eduardo-units-tuto/basics/units.ipynb.

Let me know. Thanks a lot!

eduardo-rodrigues commented 4 years ago

Lots of good points @HDembinski. Thanks very much. In a sense you are making the tutorial a lot more explanatory, which can only be good.

henryiii commented 4 years ago

Going to merge so we can see a couple of pages together.

Note: GitHub is partially down, so that's why the push is not working; it's a known issue.

henryiii commented 4 years ago

I fixed the table, by the way; you are not allowed to have a space in-between dashes and colons, jupyter-book and GitHub both don't like it:

Quantity Name Unit
Length millimeter mm
Time nanosecond ns
Energy Mega electron Volt MeV
Positron charge eplus
Temperature kelvin K
Amount of substance mole mol
Luminous intensity candela cd
Plane angle radian rad
Solid angle steradian sr

Without space:

Quantity Name Unit
Length millimeter mm
Time nanosecond ns
Energy Mega electron Volt MeV
Positron charge eplus
Temperature kelvin K
Amount of substance mole mol
Luminous intensity candela cd
Plane angle radian rad
Solid angle steradian sr
eduardo-rodrigues commented 4 years ago

Ah, I was not expecting the merge so quickly.

Just to reassure @HDembinski and @mayou36: I will create a new PR to address the remaining points of your feedback. Apologies for being slow these days.

henryiii commented 4 years ago

Until we start advertising this, let's not worry about making it perfect, but let's not forget to provide & address feedback too! Still being affected by the GitHub outages, which seem to be getting worse.

henryiii commented 4 years ago

We should put a nice structure in, and address all feedback, before we advertise. :)

eduardo-rodrigues commented 4 years ago

Aren't we agreeing, Henry? I think so. I'm just acknowledging that I'm obviously not going to ignore feedback kindly provided upon request - the obvious thing to do ;-).