scikit-hep / scikit-hep.github.io

Pages defining the website of the Scikit-HEP project.
https://scikit-hep.org
BSD 3-Clause "New" or "Revised" License
12 stars 15 forks source link

feat: add prettier #215

Closed henryiii closed 2 years ago

henryiii commented 2 years ago

Should be implemented in Cookie first.

eduardo-rodrigues commented 2 years ago

How does this interfere, if at all, with for example Black? This point may be worth a sentence.

henryiii commented 2 years ago

Pretty sure Python is not one of the languages it supports. But that's partially why it has a mention of using types_or to ensure it's not trying to change files you'd rather not be auto formatted. I should include json in the list. I'm pretty sure we don't already recommend an auto formatter for any of the supported file types.

Screen Shot 2022-05-05 at 4 46 31 PM
henryiii commented 2 years ago

Updates: I've run prettier on the website itself, and worked out a few things:

When viewing the diff, be sure to turn off whitespace in Github's viewer, it helps a little bit!